Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added protoc 3.11.4 for osx-aarch_64. #94

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cmardini
Copy link

@cmardini cmardini commented Jan 6, 2021

Built from [email protected]:protocolbuffers/protobuf.git tag v3.11.4

Symbols stripped with "strip"

Built with static linkage: ./configure --disable-shared

% otool -L bin/3.11.4/protoc-3.11.4-osx-aarch_64.exe
bin/3.11.4/protoc-3.11.4-osx-aarch_64.exe:
	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 904.4.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1292.60.1)

Note the license at: https:/protocolbuffers/protobuf/blob/master/LICENSE

Built with static linkage:  ./configure --disable-shared

Built from [email protected]:protocolbuffers/protobuf.git tag v3.11.4

Symbols stripped with "strip"

% otool -L bin/3.11.4/protoc-3.11.4-osx-aarch_64.exe
bin/3.11.4/protoc-3.11.4-osx-aarch_64.exe:
	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 904.4.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1292.60.1)
@gabriel-ozeas
Copy link

HI guys, do you have some idea when this PR will be merged and published? This will help a lot of M1 users. Thanks.

@h2000
Copy link

h2000 commented Apr 29, 2021

Hi, we need this change too. Can we help some how? Thank you!!

@os72
Copy link
Owner

os72 commented May 4, 2021

The one single thing that could unstuck this project would be to find some sponsorship. Maybe put in a word with Google or something..

@jmspring
Copy link

The one single thing that could unstuck this project would be to find some sponsorship. Maybe put in a word with Google or something..

Define "sponsorship"? As I need this I am also willing to help on it, but need it for private uses not for my current employer.

@os72
Copy link
Owner

os72 commented Jul 5, 2021

https:/sponsors

@abhivaikar
Copy link

abhivaikar commented Sep 13, 2021

Hi @os72 . Not sure if it's enough (probably not) but I just did a tiny buymeacoffee contribution for you. Just hoping that this PR is merged so that we can use this maven plugin out of the box for M1 macbooks instead of doing any complex workarounds.

@maver1ck
Copy link

Hi @os72,
Is there a chance you merge this PR ?

@Rigoberto-Vazquez
Copy link

hi @os72,
Do we have any news about this PR? or any workaround with this version of os72?

@daveish
Copy link

daveish commented Apr 14, 2022

The one single thing that could unstuck this project would be to find some sponsorship. Maybe put in a word with Google or something..

Hi @os72, you are basically saying, you would rather let this project die if there is no sponsorship to give you the resources to work on this by yourself? Why don't you accept other contributors who actually have the time to work on this in their spare time?

If you don't have the time, kindly let others do what they can. That's part of open source software, isn't it?

@clairemcginty
Copy link

Hi @os72! I confirmed that we (Spotify) were able to secure corporate sponsorship for protoc-jar. Can we unblock this PR?

@slachiewicz
Copy link

Also Google published, in latest version ready artefacts for this architecture - no longer need for custom builds

@maver1ck
Copy link

maver1ck commented May 31, 2022

There is one more option - fork.
Maybe Spotify can take this ?

@slachiewicz
Copy link

it's better - this repo can be archived! We have official artefacts from Google.

@clairemcginty plese use something like bellow

protocolbuffers/protobuf#9973

      <plugin>
        <groupId>com.github.os72</groupId>
        <artifactId>protoc-jar-maven-plugin</artifactId>
        <version>3.11.4</version>
       <configuration>
         <protocArtifact>com.google.protobuf:protoc:3.21.1</protocArtifact>

@os72
Copy link
Owner

os72 commented Jun 1, 2022

@slachiewicz - you are confusing protoc-jar-maven-plugin with protoc-jar (this project), related but not the same. and yes, both projects have supported downloads from maven central for a long time (google builds or otherwise). you don't even have to specify the artifact syntax, the program will try to find the given version on central automatically

@os72
Copy link
Owner

os72 commented Jun 1, 2022

If you don't have the time, kindly let others do what they can. That's part of open source software, isn't it?

@daveish - not sure i understand this comment, this is open to anyone to modify (keyword fork)..

@os72
Copy link
Owner

os72 commented Jun 1, 2022

Hi @os72! I confirmed that we (Spotify) were able to secure corporate sponsorship for protoc-jar. Can we unblock this PR?

hi @clairemcginty - this is awesome and very appreciated! kudos to spotify for showing some serious OSS leadership

i'm not sure the process has completed, but yes this will help unfreeze the project. hopefully word can spread (beyond just spotify) and help establish a long-term sustainable maintenance level for the project

@Naidile-PN
Copy link

When can we expect this to be merged

@andreaslanderer
Copy link

Would be really great if you could merge this any time soon

@pratyakshsharma
Copy link

By when we expect this to close?

@arturCwiklinsky
Copy link

One of workarounds for error wth protoc v3.11.4 and JDK 11.0.6 is maven goal parameter:

mvn install -Dos.arch=x86_64

@edpichler
Copy link

I tested this PR and it works perfectly.
If the maintainer cannot continue it I suggest someone who can to fork the project and allow others to contribute.

@spensonshih
Copy link

Please checkout the fork by BlackRock: https:/blackrock/protoc-jar-maven-plugin

This forked version uses Google’s Protoc version 3.25.1 by default which supports osx aarch64.

@cmardini
Copy link
Author

cmardini commented May 7, 2024

Please checkout the fork by BlackRock: https:/blackrock/protoc-jar-maven-plugin

This forked version uses Google’s Protoc version 3.25.1 by default which supports osx aarch64.

Seems like the README should refer to protoc-maven-plugin? I can only find jars under https://repo1.maven.org/maven2/io/github/blackrock/protoc-maven-plugin/2.0.0/ and not under https://repo1.maven.org/maven2/io/github/blackrock/protoc-jar-maven-plugin/2.0.0/

@spensonshih
Copy link

@cmardini , you are correct. This is a missed on my part, thank you for pointing this out. I will get this updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.