Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for PE split stack #85

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

logicminds
Copy link

This PR is essentially the same thing as #82 but with a rebase and a few template modifications.

With this feature we can now create a split install using roles defined in roles.yaml file such as the following example:

Roles: https://gist.github.com/logicminds/66506406c1038628f262
Vms: https://gist.github.com/logicminds/ff806b3814fde2a9db31

While the cmaster does have a template it will only be installed as a agent and then it will be classified as a compile master with the next puppet agent run.

@logicminds
Copy link
Author

I still need to add the cmaster classification support but everything else is working.

 * fixed typo in puppetdb answers template
 * added cmaster template
 * added symlink during install
  * while the user can always set autosign:true in the config, this
    is to ensure that the split install will always work if they do not
    set autosign to true.
@logicminds
Copy link
Author

I have found a few more issues around auto signing and puppetdb whitelist.

For some reason the puppetdb whitelist does not contain the pe-ca host which creates a chicken/egg problem. I am wondering if this should be added like

https:/oscar-stack/vagrant-pe_build/blob/master/lib/pe_build/provisioner/pe_bootstrap/post_install.rb#L82

but instead generate the whitelist ourselves. Although if the pe-installer can do this i would prefer that of course.

@adrienthebo
Copy link
Member

I'm not able to keep up with reviews, @Sharpie @reidmv @mrzarquon could you guys take a look at this one or find someone to keep this moving forward?

@logicminds
Copy link
Author

It was working great, but there is a few extra things we need to finish it off. Its been a while since I used this. I'll try and find some time to further document my changes and get this moving again.

@adrienthebo
Copy link
Member

@logicminds as you've probably seen I've been too swamped to work on many things myself and am trying to find new maintainers for projects; would you be interested in helping maintain this project, or at the least would you like a commit bit? That way you can get pull requests through even if there's not a lot of people to look at PRs.

@logicminds
Copy link
Author

@adrienthebo that would be great.

@adrienthebo
Copy link
Member

Wonderful, thank you for stepping up!

@adrienthebo
Copy link
Member

I've invited you to the vagrant-pe_build repo, if you want more access just give a shout and we can do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants