Add within support to allow iterating over IpNetworks (cidrs)

[ross]

This is akin to golang's within support, mostly implemented in https:/oschwald/maxminddb-golang/blob/main/traverse.go, but the implementation itself is done from scratch to better match the style and details of this rust implementation.

It's still a work in progress, mostly kicking the tires and iterating towards a working/clean solution. The status is roughly:

• Implement the algorithm to search for the starting node
• Stack based in-order traversal (which will be well suited to convert to an iterator)
• Implement the iterator with an item that that includes both the network and info
• Make a quick example in the spirit of lookup.rs
• Make sure this is on the right track and is something that would be shippable
• Figure out if there's a cleaner way to get the Reader's type parameter into Within to avoid having to _ it.
• Error handling
• Organize/layout the code better
• Write tests & search for edge cases
  • Especially the IPv6 bits
• Cleanup/remove prints and other debugging bits
• ...

[ross]

Fairly new to rust (in case it's not obvious) and I'm not finding a clean way to go about returning errors that happen during the walking of nodes. My searching for idiomatic patterns didn't turn anything up, but it's a tough thing to search for.

This results in some pretty ugly code below to map errors in the helper functions into Some(Err(e)). That seems bad enough, but currently have have things in match Ok/Err conditionals that make it tough to read. Things like .map_err won't let me wrap with Some so I don't see a cleaner way. Seems like either a shortcoming of iterators or I'm just going about this all wrong 😁

Input/thoughts/suggestions welcome.

[ross]

Looks like there may be a crate, https://docs.rs/fallible-iterator/0.2.0/fallible_iterator/ that calls out the situation.

Seems like using it might be the cleaner way to go, but will defer to more experienced opinions.

[ross]

I have a FallibleIterator based solution and it cleans up pretty much all of the ugliness in error handling here. It's not perfect since you can't use for x in y, and have to go with while let Some(x) = y.next(), but that's a limitation of rust and seems like a reasonable tradeoff for cleaner error handling.

Changes for that can be seen with https:/ross/maxminddb-rust/compare/within-support...ross:within-support-fallibleiterator?expand=1. Thoughts welcome.

[oschwald]

Although it does clean up the code somewhat, I think I'd prefer not having the dependency, especially given that the fallible iterator crate hasn't seen an update in two years and doesn't seem that widely used.

[ross]

I think it hasn't seen any updates b/c it does what it needs to do. Similar to how I wrote requests-futures 8 years ago and haven't really touched it meaningfully in most of that time.

As for not wanting the dep, I don't have a response to that. The code to implement the non-fallible iterator is ugly as hell, but using it isn't THAT bad. Kind of seems like a shortcoming of Rust itself that iterators can't fail.

I'll stick this back on my TODO list to pick back up and see if I can get it over the line.

[ross]

I think this is ready for 👀 now.

[oschwald]

Sorry for the delay! I forgot about this PR. I've merged it via the CLI. One notable change that I made is that it now skips aliases of the IPv4 network (besides ::/96). I think this is the behavior that generally makes the most sense.

I plan on releasing later today.