Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct process information caching and command line retrieval under Windows #527

Merged
merged 1 commit into from
Jun 21, 2018

Conversation

dustin-johnson
Copy link
Contributor

For the most part command line retrieval appears to be broken under Windows. When investigating the issue, I found that process caching also appears a bit suspect, so I tweaked that logic a bit as well. Since the changes are concise, I'll let the diff speak for the details.

@coveralls
Copy link

coveralls commented Jun 21, 2018

Coverage Status

Coverage remained the same at 91.279% when pulling eda4cac on seeq12:bugfix/windows-get-command-line into dc624b0 on oshi:master.

@codecov-io
Copy link

codecov-io commented Jun 21, 2018

Codecov Report

Merging #527 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #527   +/-   ##
=========================================
  Coverage     83.92%   83.92%           
  Complexity      194      194           
=========================================
  Files            28       28           
  Lines          1400     1400           
  Branches        200      200           
=========================================
  Hits           1175     1175           
  Misses          105      105           
  Partials        120      120

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc624b0...eda4cac. Read the comment docs.

@dbwiddis
Copy link
Member

D’oh!

@dbwiddis dbwiddis merged commit 00bf62e into oshi:master Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants