Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows XP Compatibility Fixes #735

Merged
merged 7 commits into from
Jan 7, 2019
Merged

Windows XP Compatibility Fixes #735

merged 7 commits into from
Jan 7, 2019

Conversation

dbwiddis
Copy link
Member

@dbwiddis dbwiddis commented Jan 6, 2019

Fixes #732

@codecov-io
Copy link

codecov-io commented Jan 6, 2019

Codecov Report

Merging #735 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #735   +/-   ##
=========================================
  Coverage     82.64%   82.64%           
  Complexity      198      198           
=========================================
  Files            28       28           
  Lines          1527     1527           
  Branches        224      224           
=========================================
  Hits           1262     1262           
  Misses          127      127           
  Partials        138      138

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc57598...979636f. Read the comment docs.

@coveralls
Copy link

coveralls commented Jan 6, 2019

Coverage Status

Coverage remained the same at 90.504% when pulling 979636f on dbwiddis:master into cc57598 on oshi:master.

@dbwiddis
Copy link
Member Author

dbwiddis commented Jan 6, 2019

This pull request introduces 1 alert when merging b60199e into cc57598 - view on LGTM.com

new alerts:

  • 1 for Result of multiplication cast to wider type

Comment posted by LGTM.com

@dbwiddis
Copy link
Member Author

dbwiddis commented Jan 6, 2019

This pull request introduces 1 alert when merging f01f4e8 into cc57598 - view on LGTM.com

new alerts:

  • 1 for Result of multiplication cast to wider type

Comment posted by LGTM.com

@dbwiddis
Copy link
Member Author

dbwiddis commented Jan 6, 2019

This pull request introduces 1 alert when merging e5f0dfb into cc57598 - view on LGTM.com

new alerts:

  • 1 for Result of multiplication cast to wider type

Comment posted by LGTM.com

@oshi oshi deleted a comment Jan 6, 2019
@dbwiddis dbwiddis mentioned this pull request Jan 6, 2019
@dbwiddis
Copy link
Member Author

dbwiddis commented Jan 7, 2019

This pull request introduces 1 alert when merging 1e2ee91 into cc57598 - view on LGTM.com

new alerts:

  • 1 for Result of multiplication cast to wider type

Comment posted by LGTM.com

@dbwiddis
Copy link
Member Author

dbwiddis commented Jan 7, 2019

This pull request introduces 1 alert when merging 48b9a40 into cc57598 - view on LGTM.com

new alerts:

  • 1 for Result of multiplication cast to wider type

Comment posted by LGTM.com

@dbwiddis
Copy link
Member Author

dbwiddis commented Jan 7, 2019

This pull request introduces 1 alert when merging 979636f into cc57598 - view on LGTM.com

new alerts:

  • 1 for Result of multiplication cast to wider type

Comment posted by LGTM.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants