Add toString methods to disk and partition API #943
Conversation
| public String toString() { | ||
| boolean readwrite = getReads() > 0 || getWrites() > 0; | ||
| StringBuilder sb = new StringBuilder(); | ||
| sb.append(' ').append(getName()).append(": "); |
There was a problem hiding this comment.
Can we leave the space on the SystemInfoTest class and start this one with the name?
| sb.append(" (").append(readwrite ? FormatUtil.formatBytes(getReadBytes()) : "?").append("), "); | ||
| sb.append("writes: ").append(readwrite ? getWrites() : "?"); | ||
| sb.append(" (").append(readwrite ? FormatUtil.formatBytes(getWriteBytes()) : "?").append("), "); | ||
| sb.append("xfer: ").append(readwrite ? getTransferTime() : "?").append("\n"); |
There was a problem hiding this comment.
Let's not add the trailing new-line here.
| @Override | ||
| public String toString() { | ||
| StringBuilder sb = new StringBuilder(); | ||
| sb.append(" |-- ").append(getIdentification()).append(": "); |
There was a problem hiding this comment.
Similar to earlier comment let's keep the indentation (" |-- ") in the SystemInfoTest output and start the toString with text.
| sb.append("(").append(getType()).append(") "); | ||
| sb.append("Maj:Min=").append(getMajor()).append(":").append(getMinor()).append(", "); | ||
| sb.append("size: ").append(FormatUtil.formatBytesDecimal(getSize())); | ||
| sb.append(getMountPoint().isEmpty() ? "" : " @ " + getMountPoint()).append("\n"); |
There was a problem hiding this comment.
And similar to earlier, don't include the newline in the toString. If needed for the output, add in the other class (but it may not be needed there).
Codecov Report
@@ Coverage Diff @@
## master #943 +/- ##
============================================
+ Coverage 74.85% 75.14% +0.28%
Complexity 2 2
============================================
Files 22 22
Lines 1038 1058 +20
Branches 130 137 +7
============================================
+ Hits 777 795 +18
Misses 204 204
- Partials 57 59 +2
Continue to review full report at Codecov.
|
dbwiddis
changed the title
Removed leading or trailing whitespace/newline/characters.
|
Looks great! I tweaked some formatting, removed an unneeded null check, and added a test and changelog entry. Will merge as soon as the CI tests finish! Thanks for contributing to open source! |
|
Thanks for the opportunity! |
HWDiskStore & HWPartition toString Methods for #942