ignition-math[6,7]: depend on pybind11 #1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
It has some test failures Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
This was referenced Jan 26, 2022
j-rivero
reviewed
Jan 26, 2022
Formula/ignition-math6.rb
Outdated
| @@ -16,6 +16,7 @@ class IgnitionMath6 < Formula | |||
| depends_on "doxygen" => :build | |||
| depends_on "eigen" | |||
| depends_on "ignition-cmake2" | |||
| depends_on "pybind11" | |||
There was a problem hiding this comment.
Suggested change
| depends_on "pybind11" | |
| depends_on "pybind11" => :build |
Is pybind11 a build dependency only? Looking into the debian packaging seems so to me.
There was a problem hiding this comment.
the :build flag ensures that a dependency is installed when building bottles but not when a bottle is installed. In order to ensure that we have pybind11 installed in our CI, we need to upgrade our CI scripts. I will accept this change and open a PR to fix the release-tools scripts accordingly
chapulina
approved these changes
Jan 26, 2022
Signed-off-by: Steve Peters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #1776 without swig. Pairs with gazebosim/gz-math#361.