Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup old science values and improve initial subscription #106

Merged
merged 3 commits into from
Dec 8, 2021

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Dec 4, 2021

This addresses this comment by @mabelzhang : #93 (comment)

switch_science


  • Added services for all FloatVs, which were missing. This is needed to get the data on demand, since Ignition Transport doesn't support latching.
  • Make the FloatV optional. This is not a use case here, but I think it's a nice-to-have when we upstream.
  • Instead of skipping NaNs when displaying, send a DELETE_MARKER command, so that if the data changes from valid to NaN it disappears.
  • Removed the - from the marker namespaces because it looked awkward when there's no float topic

Copy link
Collaborator

@mabelzhang mabelzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended. I see what you mean by the warnings.
So I'm actually unclear on why they have to be deleted again. I thought ClearMarkers() is called in OnFloatVTopic(), so shouldn't all the points already get deleted whenever the topic is switched?

Copy link
Collaborator

@mabelzhang mabelzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will let you merge since we have some specific order of merging at the moment.

@chapulina
Copy link
Contributor Author

I thought ClearMarkers() is called in OnFloatVTopic(), so shouldn't all the points already get deleted whenever the topic is switched?

Good point, maybe it's a timing thing? I should dig more later. I'll merge this now to unblock other PRs.

@chapulina chapulina merged commit dc74ea8 into main Dec 8, 2021
@chapulina chapulina deleted the chapulina/cleanup_science branch December 8, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants