Battery calculation #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
iche033
reviewed
Jan 11, 2022
| # calculate battery capacity from time | ||
| # capacity (Ah) = flight time (in hours) * load (watts) / voltage | ||
| # assume constant voltage for battery to keep things simple for now. | ||
| battery_capacity = (float(flight_time) / 60) * 6.6 / 12.694 |
There was a problem hiding this comment.
I tried a flightTime of 5 (min?) and this gives me 0.043327. Seems a little low? Battery ran out quickly.
There was a problem hiding this comment.
The calculation is correct. The problem was due to gazebosim/gz-sim#225. Fixed in afaa010 . I've opened #11 which has a unit test which tests the discharge time.
There was a problem hiding this comment.
I see, nice it's working well now.
We should probably remove the fix_issue_225 in Garden. I see a note there to remove it in Dome..
Signed-off-by: Arjo Chakravarty <[email protected]>
iche033
approved these changes
Jan 12, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simple formula to limit the battery operation to a fixed amount of time. It does so by adding the
flightTimeargument to thespawn.launch.py. A second PR with the relevant unit tests is in the works.