tests: More fixture rework, port test-diff to new path #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
test-fixture-ng5
branch
2 times, most recently
from
b9e5cc2
to
228ffc0
Compare
|
After this the next step is to port everything to the new fixture, and drop the hardcoded tarballs. |
Currently the fixture is just built during `cargo test`; to help debug it I wanted to support it being part of our main shared library in the "integrationtest" path. For example I want to add a CLI method to stand up the fixture directory (but not delete it). But the other big thing going on here is that we now support updating commits fully in memory, and so the diff API is ported to use this. This requires ostreedev/ostree#2548
cgwalters
force-pushed
the
test-fixture-ng5
branch
from
228ffc0
to
b516c24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the fixture is just built during
cargo test; to helpdebug it I wanted to support it being part of our main shared
library in the "integrationtest" path. For example I want to add
a CLI method to stand up the fixture directory (but not delete it).
But the other big thing going on here is that we now support updating
commits fully in memory, and so the diff API is ported to use this.
This requires ostreedev/ostree#2548