Fix CI tests #1892
Closed
Fix CI tests #1892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbnicholson
force-pushed
the
fix-ci
branch
2 times, most recently
from
c9e2317
to
82784ef
Compare
This wasn't available when I originally wrote this, but it ensures that the running gpg-agent in tmpgpghome is killed in case the tests exit early.
The ability to expire subkeys using gpg's --quick-set-expire is only available on gnupg 2.1.22. If expiring a subkey fails, assume this is why and skip the tests that require it but run the actions that the subsequent tests depend on. This was failing on the Debian Stretch CI tests since stretch has gnupg 2.1.18.
Move the OstreeKernelArgs autoptr cleanup definition to ostree-autocleanups.h, which will only expose the definitions when building ostree or if glib is new enough. The include of ostree-kernel-args.h needs to be moved before ostree-autocleanups.h in ostree.h so that the OstreeKernelArgs type is declared when the autoptr cleanup is defined. All the places it's used already pull in libglnx.h first so that the compat macros are picked up if glib it too old during the ostree build.
|
I did what I could but I don't believe I can fix the Anyways, this is ready for review. |
jlebon
reviewed
Jul 26, 2019
I'll give it a shot. |
The test-ucontainer.sh test in rpmostree 2019.1 is failing for non-ostree reasons. This is fixed in [1], which is part of 2019.3. I believe this is still a relevant test of f29 since that's what's shipped in f29-updates. 1. coreos/rpm-ostree@45b6186
|
All tests passing now. I forget, does homu take care of squashing my fixups or should I rewrite the history myself? |
|
Homu will squash. Thanks so much for doing this! I owe you 🍻 |
Well, one of them I introduced myself, so 😛 |
|
@cgwalters it doesn't look like the merge was initiated. |
|
All green, beautiful!
Ahh yup, we're missing an |
|
⚡ Test exempted: merge already tested. |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Jul 27, 2019
The ability to expire subkeys using gpg's --quick-set-expire is only available on gnupg 2.1.22. If expiring a subkey fails, assume this is why and skip the tests that require it but run the actions that the subsequent tests depend on. This was failing on the Debian Stretch CI tests since stretch has gnupg 2.1.18. Closes: #1892 Approved by: jlebon
rh-atomic-bot
pushed a commit
that referenced
this pull request
Jul 27, 2019
Move the OstreeKernelArgs autoptr cleanup definition to ostree-autocleanups.h, which will only expose the definitions when building ostree or if glib is new enough. The include of ostree-kernel-args.h needs to be moved before ostree-autocleanups.h in ostree.h so that the OstreeKernelArgs type is declared when the autoptr cleanup is defined. All the places it's used already pull in libglnx.h first so that the compat macros are picked up if glib it too old during the ostree build. Closes: #1892 Approved by: jlebon
rh-atomic-bot
pushed a commit
that referenced
this pull request
Jul 27, 2019
The test-ucontainer.sh test in rpmostree 2019.1 is failing for non-ostree reasons. This is fixed in [1], which is part of 2019.3. I believe this is still a relevant test of f29 since that's what's shipped in f29-updates. 1. coreos/rpm-ostree@45b6186 Closes: #1892 Approved by: jlebon
d4s
pushed a commit
to d4s/ostree
that referenced
this pull request
Nov 4, 2019
This wasn't available when I originally wrote this, but it ensures that the running gpg-agent in tmpgpghome is killed in case the tests exit early. Closes: ostreedev#1892 Approved by: jlebon
d4s
pushed a commit
to d4s/ostree
that referenced
this pull request
Nov 4, 2019
The ability to expire subkeys using gpg's --quick-set-expire is only available on gnupg 2.1.22. If expiring a subkey fails, assume this is why and skip the tests that require it but run the actions that the subsequent tests depend on. This was failing on the Debian Stretch CI tests since stretch has gnupg 2.1.18. Closes: ostreedev#1892 Approved by: jlebon
d4s
pushed a commit
to d4s/ostree
that referenced
this pull request
Nov 4, 2019
Move the OstreeKernelArgs autoptr cleanup definition to ostree-autocleanups.h, which will only expose the definitions when building ostree or if glib is new enough. The include of ostree-kernel-args.h needs to be moved before ostree-autocleanups.h in ostree.h so that the OstreeKernelArgs type is declared when the autoptr cleanup is defined. All the places it's used already pull in libglnx.h first so that the compat macros are picked up if glib it too old during the ostree build. Closes: ostreedev#1892 Approved by: jlebon
d4s
pushed a commit
to d4s/ostree
that referenced
this pull request
Nov 4, 2019
The test-ucontainer.sh test in rpmostree 2019.1 is failing for non-ostree reasons. This is fixed in [1], which is part of 2019.3. I believe this is still a relevant test of f29 since that's what's shipped in f29-updates. 1. coreos/rpm-ostree@45b6186 Closes: ostreedev#1892 Approved by: jlebon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the CI tests are always failing, which makes it hard to know if your PR is adding new failures.