lib/checkout: use canonical permissions in bare-user-only mode #2415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new `OSTREE_CHECKSUM_FLAGS_CANONICAL_PERMISSIONS` checksumming flag, which is needed in bare-user-only mode to ignore local IDs.
This was referenced Aug 19, 2021
|
This locally passed a non-root |
cgwalters
reviewed
Aug 19, 2021
tests/test-basic-user-only.sh
Outdated
| ostree_repo_init repo init --mode=bare-user-only | ||
| rm files -rf && mkdir files | ||
| echo afile > files/afile | ||
| $OSTREE --repo=repo commit ${COMMIT_ARGS} -b perms files |
There was a problem hiding this comment.
Shouldn't we be running ostree fsck here?
There was a problem hiding this comment.
Ack, I've added it.
Although this PR is not the fix for #2410.
ostree fsck only happens to work here because ${COMMIT_ARGS} values let this test land on a happy path.
This automatically enables canonical permissions for checkouts in bare-user-only mode.
lucab
force-pushed
the
ups/checksum-canonical-perms
branch
from
afaad7a
to
d41fcd1
Compare
jlebon
approved these changes
Aug 19, 2021
| @@ -31,7 +31,7 @@ if is_bare_user_only_repo repo; then | |||
| # In bare-user-only repos we can only represent files with uid/gid 0, no | |||
| # xattrs and canonical permissions, so we need to commit them as such, or | |||
| # we end up with repos that don't pass fsck | |||
| COMMIT_ARGS="--canonical-permissions" | |||
| COMMIT_ARGS="--canonical-permissions --no-xattrs" | |||
There was a problem hiding this comment.
I guess this is the bit we should be able to get rid of once we fix the commit side of this.
There was a problem hiding this comment.
Yes, it is the same workaround we suggested at #2410 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
OSTREE_CHECKSUM_FLAGS_CANONICAL_PERMISSIONSchecksumming flag, which is needed in bare-user-only mode
to ignore local IDs.
It also automatically enables canonical permissions for checkouts in
bare-user-only mode.