Add test for Walk

all_test.go

@@ -11,6 +11,7 @@ import (
 
  "github.com/otiai10/marmoset"
  . "github.com/otiai10/mint"
+ "golang.org/x/net/html"
 )
 
 func TestNew(t *testing.T) {
@@ -115,6 +116,26 @@ func TestFetchWithContext(t *testing.T) {
  cancel100ms()
 }
 
+func TestOpenGraph_Walk(t *testing.T) {
+ s := dummyServer(2)
+ res, err := http.Get(s.URL)
+ Expect(t, err).ToBe(nil)
+
+ node, err := html.Parse(res.Body)
+ Expect(t, err).ToBe(nil)
+
+ og := New(s.URL)
+ err = og.Walk(node)
+ Expect(t, err).ToBe(nil)
+ Expect(t, og.Title).ToBe("はいさいナイト")
+ res.Body.Close()
+
+ again := New(s.URL)
+ err = again.Walk(node)
+ Expect(t, err).ToBe(nil)
+ Expect(t, again.Title).ToBe("はいさいナイト")
+}
+
 func dummyServer(id int) *httptest.Server {
  marmoset.LoadViews("./test/html")
  r := marmoset.NewRouter()

opengraph.go

@@ -138,15 +138,20 @@ func (og *OpenGraph) Parse(body io.Reader) error {
  if err != nil {
  return err
  }
- og.Walk(node)
+ og.walk(node)
  return nil
 }
 
+// Walk scans HTML nodes to pick up meaningful OGP data.
+func (og *OpenGraph) Walk(n *html.Node) error {
+ return og.walk(n)
+}
+
 func (og *OpenGraph) satisfied() bool {
  return false
 }
 
-func (og *OpenGraph) Walk(n *html.Node) error {
+func (og *OpenGraph) walk(n *html.Node) error {
  if og.satisfied() {
  return nil
  }
@@ -166,7 +171,7 @@ func (og *OpenGraph) Walk(n *html.Node) error {
  }
 
  for child := n.FirstChild; child != nil; child = child.NextSibling {
- og.Walk(child)
+ og.walk(child)
  }
 
  return nil