Fix a crash due to the access violation when DialogBoxIndirectParamA is called #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I found the access violation is occurred when DialogBoxIndirectParamA() is called in DIALOG_CreateIndirect16() if icon or bitmap resource is exists in the dialog template.
According to stack trace when the access violation is occurred, it seems to try to access resources which is exist in NE file from PE while DialogBoxIndirectParamA() is calling.
To avoid this, I add a workaround that uses the extra data instead of the resource name directly. After apply this fix, DialogBoxIndirectParamA() is working correctly without the access violation as below: