Patch #11858
Merged
Patch #11858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ @zackradisic, your commit has failing tests :( 💻 1 failing tests Darwin x64 baseline
🐧💪 1 failing tests Linux AARCH64
🪟💻 1 failing tests Windows x64 baseline
🪟💻 1 failing tests Windows x64
|
9 tasks
|
| const pkg = lockfile.packages.get(pkg_id); | ||
| if (version) |v| { | ||
| const label = std.fmt.bufPrint(buf[0..], "{}", .{pkg.resolution.fmt(strbuf, .posix)}) catch @panic("Resolution name too long"); | ||
| if (std.mem.eql(u8, label, v)) break :brk .{ @intCast(dep_id), pkg_id }; |
There was a problem hiding this comment.
This feels like not a great way to do it but I'm not sure
@dylan-conway wdyt
There was a problem hiding this comment.
hmm yeah this won't work if version is a range like ^4.0.0 because the resolution will have the exact version. I'm not sure if version ranges are allowed with pnpm patch so it might be fine
| .{name}, | ||
| ); | ||
| var i: usize = 0; | ||
| const pkg_hashes = lockfile.packages.items(.name_hash); |
There was a problem hiding this comment.
in the future, this is where you would get the package_id for the current workspace and only loop through it's packages, instead of all packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #11719
bun patch --commit