Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable iterator-helpers in webkit #14455

Merged
merged 1 commit into from
Oct 10, 2024
Merged

enable iterator-helpers in webkit #14455

merged 1 commit into from
Oct 10, 2024

Conversation

nektro
Copy link
Contributor

@nektro nektro commented Oct 10, 2024

Closes #14426

before

❯ ./build/debug/bun-debug --print '[1,2,3][Symbol.iterator]().toArray()'
1 | [1,2,3][Symbol.iterator]().toArray()
                               ^
TypeError: [1, 2, 3][Symbol.iterator]().toArray is not a function. (In '[1, 2, 3][Symbol.iterator]().toArray()', '[1, 2, 3][Symbol.iterator]().toArray' is undefined)
      at /Users/meghandenny/src/bun/[eval]:1:28
      at asyncFunctionResume (1:11)
      at promiseReactionJobWithoutPromiseUnwrapAsyncContext (1:11)
      at promiseReactionJob (1:11)

after

❯ ./build/debug/bun-debug --print '[1,2,3][Symbol.iterator]().toArray()'
[ 1, 2, 3 ]

@robobun
Copy link

robobun commented Oct 10, 2024

@nektro, your commit 985b805 has 11 failures in #4608:

  • test/v8/v8.test.ts - 23 failing on 🐧 20.04 aarch64
  • test/js/web/fetch/fetch-tcp-stress.test.ts - timeout on 🍎 14 aarch64
  • test/js/web/fetch/fetch-tcp-stress.test.ts - timeout on 🍎 14 x64
  • test/js/web/streams/streams.test.js - 1 failing on 🍎 13 aarch64
  • test/js/node/test/parallel/zlib.test.js - 1 failing on 🍎 14 aarch64
  • test/js/bun/http/fetch-file-upload.test.ts - 1 failing on 🪟 x64-baseline
  • test/js/bun/http/fetch-file-upload.test.ts - 1 failing on 🪟 x64
  • test/cli/watch/watch.test.ts - 2 failing on 🪟 x64
  • test/cli/watch/watch.test.ts - 2 failing on 🪟 x64-baseline
  • test/bundler/bundler_compile.test.ts - 5 failing on 🪟 x64
  • test/js/node/fs/fs-promises-writeFile-async-iterator.test.ts - timeout on 🍎 14 aarch64
  • test/cli/hot/watch.test.ts - 1 failing on 🪟 x64-baseline
  • test/cli/hot/watch.test.ts - 1 failing on 🪟 x64
  • test/js/bun/http/bun-serve-static.test.ts - 1 failing on 🍎 14 aarch64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🍎 13 aarch64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🍎 14 aarch64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🪟 x64-baseline
  • test/bundler/bun-build-api.test.ts - 3 failing on 🪟 x64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🍎 14 x64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🍎 13 x64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 22.04 x64-baseline
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 20.04 x64-baseline
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 12 x64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 12 x64-baseline
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 22.04 x64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 20.04 x64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 20.04 aarch64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 22.04 aarch64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 12 aarch64
  • @nektro nektro marked this pull request as ready for review October 10, 2024 06:15
    @Jarred-Sumner Jarred-Sumner merged commit 584a8ce into main Oct 10, 2024
    25 checks passed
    @Jarred-Sumner Jarred-Sumner deleted the nektro-patch-19425 branch October 10, 2024 22:48
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    Implement iterator-helpers
    3 participants