Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for completion in Bash #403

Merged
merged 20 commits into from
Jul 25, 2022
Merged

Support for completion in Bash #403

merged 20 commits into from
Jul 25, 2022

Conversation

zombieleet
Copy link
Contributor

@zombieleet zombieleet commented Jul 8, 2022

This PR adds support for buns autocompletion in bash.

@zombieleet zombieleet marked this pull request as ready for review July 8, 2022 03:33
Copy link
Collaborator

@evanwashere evanwashere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autocomplete for files is missing? eg bun run t[TAB] -> bun run test.js
install.sh needs to be modified to automatically install bash completions if it's bash shell

@zombieleet
Copy link
Contributor Author

zombieleet commented Jul 8, 2022

@evanwashere I think the file I need to edit for installing bash completions is install_completions_command.zig

cc: @Jarred-Sumner

@Jarred-Sumner
Copy link
Collaborator

This is great!

@Jarred-Sumner Jarred-Sumner merged commit 8a43083 into oven-sh:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants