Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(examples/hono): refine Hono example #773

Merged
merged 6 commits into from
Jul 24, 2022
Merged

fix(examples/hono): refine Hono example #773

merged 6 commits into from
Jul 24, 2022

Conversation

yusukebe
Copy link
Contributor

  • Bump up Hono version number
  • Simplify the script
  • Add tests

@yusukebe
Copy link
Contributor Author

Hi!

Resolved conflict.

@LoiLock
Copy link
Contributor

LoiLock commented Jul 20, 2022

Is the version bump to 2.0.2 really necessary? ^2.0.0 matches 2.0.2 as well, so it will install this as well

@yusukebe
Copy link
Contributor Author

@LoiLock

Sorry, it's not necessary. fixed it.

@FinnRG
Copy link
Collaborator

FinnRG commented Jul 21, 2022

The wiptest function is still a WIP, so I wouldn't include it in a template.

@yusukebe
Copy link
Contributor Author

Hi @FinnRG

I've removed the test. If the wiptest become not a WIP, I'll use it.
Thank you!

@FinnRG FinnRG merged commit 7896361 into oven-sh:main Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FinnRG FinnRG FinnRG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yusukebe @LoiLock @FinnRG