Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ipc): add json ipc type + buffer incoming messages until a listener is attached. #8733

Merged
merged 17 commits into from
Apr 1, 2024

Conversation

paperdave
Copy link
Member

@paperdave paperdave commented Feb 6, 2024

What does this PR do?

  • Next.js App Router Works. Edge Runtime is not done
  • serialization: json in child_process
  • Fix console.log edge cases, and a crash when passing a non-object with %o.

Related Task: #5852
Might Fix, check #4795
Might Fix, check #4671
Fixes #1472
Fixes #5956
Fixes #5814
Fixes #3351
Fixes #3776
Fixes #8725
Fixes #7812
Fixes #8955 (by using json instead of advanced)
Fixes #7401 because i was bored

Copy link
Contributor

github-actions bot commented Feb 6, 2024

Copy link
Contributor

github-actions bot commented Feb 6, 2024

Copy link
Contributor

github-actions bot commented Feb 6, 2024

@Electroid Electroid self-requested a review February 7, 2024 00:34
src/bun.js/api/bun/subprocess.zig Outdated Show resolved Hide resolved
@paperdave
Copy link
Member Author

This PR now supercedes #7565

@Jarred-Sumner Jarred-Sumner marked this pull request as ready for review April 1, 2024 08:50
@Jarred-Sumner Jarred-Sumner merged commit 81badba into main Apr 1, 2024
26 of 31 checks passed
@Jarred-Sumner Jarred-Sumner deleted the dave/ipc-fix-2 branch April 1, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment