🔨 extract explorers to lerna package #4031
Draft
+855
−193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikesau
force-pushed
the
explorer-lerna-package
branch
from
3a0a791
to
7f3d442
Compare
ikesau
force-pushed
the
explorer-lerna-package
branch
from
7f3d442
to
63c2a85
Compare
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-10-09 21:34:05 UTC |
ikesau
force-pushed
the
explorer-lerna-package
branch
from
63c2a85
to
25b766d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved
gridLangandexplorerto a single lerna sub-package.4 values from
clientSettingswere hardcoded during transpilation, so I extracted those as props and pass them torenderSingleExplorerOnExplorerPageand hardcode them in theMultiEmbedder.I've done some very provisional testing and things seem OK.
Currently nothing is exported that doesn't need to be, but the idea behind this work is that it might be useful to be able to import the DecisionMatrix in a CF Worker.