✨ (scatter) don't animate as a time scatter #4038
Open
+100
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sophiamersmann and the rest of your teammates on |
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-10-08 15:28:59 UTC |
sophiamersmann
force-pushed
the
scatter-animation
branch
5 times, most recently
from
71e0c7c
to
26f3537
Compare
sophiamersmann
force-pushed
the
scatter-animation
branch
from
26f3537
to
a9b08c8
Compare
2 tasks
packages/@ourworldindata/grapher/src/scatterCharts/ScatterPlotChart.tsx
Outdated
Show resolved
Hide resolved
sophiamersmann
force-pushed
the
scatter-animation
branch
from
a9b08c8
to
72634c9
Compare
This was referenced Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Animates a scatter as a cloud of moving dots and keeps the axes fixed. The axes are fixed for the particular time range that is animated.
At the animation's beginning and end, the view "jumps" to the new axis domains. The same happens when an animation is paused and the user starts dragging one of the sliders.
The animation in relative mode is unchanged. Getting the right axis domain doesn't seem trivial to me unless I'm missing something, so it's not worth doing at this point IMO.
In a follow-up PR, I'll also look into fixing the size domain.