Skip to content
This repository has been archived by the owner on Nov 14, 2018. It is now read-only.

Updated utils.js to hide saml logo after ldap login. #2169

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rr-paras-patel
Copy link

In my organisation we use owncloud-LDAP authentication since long time(2 year). according to time change we need to adopt new technologies and secure method so we recently we decide to enable ADFS-SSO authentication using SAML. we configured it correctly. and it is working fine.

But issue happen when we enable both authentication LDAP + ADFS-SAML simultaneously. because organization some user want to use LDAP some prefer ADFS-SSO. and also to share file with those new user who have never signed-up or sign-in yet. we can't remove LDAP integration because we want to fetch user's list from Active Directory to share files with them.Note: In scenario of ADFS-SSO once user will signup his/her entry created inside oc_users table and then we can share file with them. in this scenario if person use LDAP auth first time to sign-in SAML-login logo don't hide. This one:
image

it hovers on home screen after login. so i proposed this pull request to solve this issue.

@rr-paras-patel
Copy link
Author

any update or review on this PR? if you need more detail i can provide.

@rr-paras-patel
Copy link
Author

@MorrisJobke any comment ?

@MorrisJobke
Copy link
Contributor

maybe someone from @owncloud/javascript want to have a look :)

@DeepDiver1975
Copy link
Contributor

@patelparas you can try to ask people who contributed to this app in the past to review

@kazsw @kralizeck @mirekys @adobo @pitbulk @sigmunau

@PVince81
Copy link
Contributor

PVince81 commented Jul 1, 2016

The code looks fine, but I don't have an environment to test this

@rr-paras-patel
Copy link
Author

Actually i have developed and tested. and deployed SAML-ADFS in my Production in Feb-2016. it is working fine we didn't find any issue yet...... but again you need to check with latest version......

@rr-paras-patel
Copy link
Author

and user_saml app need other changes also like.....
e.g. in case of user use ObjectGUID as uid a need to decode GUID like this:

public static function base64ToobjectGUID($guid_b64) {
            $guid_bin = base64_decode($guid_b64);
            return join('-', array(
                bin2hex(strrev(substr($guid_bin, 0, 4))),
                bin2hex(strrev(substr($guid_bin, 4, 2))),
                bin2hex(strrev(substr($guid_bin, 6, 2))),
                bin2hex(substr($guid_bin, 8, 2)),
                bin2hex(substr($guid_bin, 10, 6))
            ));
 }

I think we need to rewrite SimplePHPSAML deployment and integration manual step by step. existing one is not sufficient. i know individual contributor will not take interest in this contribution because ADFS-SSO is need for Enterprise Use Case only.

@PVince81
Copy link
Contributor

One question is whether this change would be unacceptable for other SAML user, or compatible ?
If not, then maybe this needs a config switch where this is disabled by default.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants