Make compatible with IE 11 #206
Conversation
|
Might on some machines require owncloud/core#17791 |
|
Server: oC master
All I get is the spinning wheel. |
That's not really descriptive. What fails? How does it fail? etc. ;-)
Are you sure you're not running into owncloud/gallery#159? |
|
Especially since it really confuses me that it fails under all browsers. ;-) – Please take a look at your console. Maybe Gallery+ running amok in combination with it? ;-) |
Yeah, I edited my comment later to add that I just get the spinning wheel, sorry. Doing some more tests, I can see that Pictures fails, regardless of your fix, so there must be something it doesn't like, maybe a svg file? That's one reason I don't see the point in fixing that branch. There are way too many issues. |
|
Looking at the files I have, it's the samples used for tests + a corrupt file. The latter is probably what Pictures chokes on. |
|
Even without the corrupt jpeg it doesn't work. I can see the thumbnails being streamed back, but they're never displayed. |
You shall be more specific and share your example files 🙊 |
It simply is about getting a minimum viable app. Honestly, this is not about fixing all the thousand issues in this app. I know that there are a ton of (such as the famous REQUEST_URI one) but we have to get it work at least somewhat. So don't test any strange test cases which anyways will fail also on master on other browsers ;-) |
|
Also please don't have any non-default preview providers enabled etc. 🙊 |
|
@LukasReschke THANK YOU! I can confirm that commit 6310209 fixes the issue for IE9, 10 & 11. I keep my redirect for IE7 & 8 to maintain compatibility for publicly shared albums for people who refuse to update... in /var/www/owncloud/.htaccess under RewriteEngine on: RewriteCond %{HTTP_USER_AGENT} "MSIE 7" [NC,OR] |
It already exists. stable8 and stable8.1 in owncloud/gallerplus are compatible with IE11 and can be improved if compatibility with IE8 is required.
I agree that it's best to start with something simple, but what's the point if it only works for the demo, but not in real-life situations? |
|
@oparoz Adding GalleryPlus as default is not an option for older stable releases. 8.2: Maybe. Older releases: No. |
|
Thanks @gsosna. |
|
@LukasReschke - OK |
|
Very nice guys 👍 |
|
👍 Gallery app 0.6.1. does not appear the spinner now. Great!!! browser: Internet Explorer 11.0.9600.17843 |
Make compatible with IE 11
|
Stable8.1: owncloud/gallery#208 |
|
@gsosna - Just to be sure, you've tested on a live installation with lots of pictures and folders, correct? |
|
@LukasReschke @oparoz please make sure this improvement is also in Gallery+ :) |
|
@jancborchardt - Yes, I will check if I get the same results in Gallery |
|
@oparoz yes, i tested on a live install, and the commit 6310209 fixed the problem with my installation and the shared pictures. But there seems to be another problem with large galleries unrelated to this fix - where you can still navigate between different directories, and they work fine, it's only a particular directory that doesn't work. Perhaps something to do with filenames or amount of files in that directory - nothing showing in console... perhaps the same as owncloud/gallery#21 |
|
Thanks for the feedback @gsosna . If that directory doesn't work only in IE, then it could be related to that strange issue, if all browsers bail, then it's probably something else, but the good news is that it doesn't prevent you from accessing Pictures like some bugs do. |
|
@oparoz Correct. Just that directory and just on IE. |
|
Cool. Feel free to open a new issue about it here if you think this needs to be addressed in 8.1. |
Fixes owncloud/gallery#173 and owncloud/gallery#193
At least the app loads again locally for me. - Though I did some more changes and may have cleaned the cache wrongly so please check on your machines as well.