Add bgcolor and adopt the height of the video scrubber #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PVince81
reviewed
Sep 18, 2020
src/styles/_viewerControls.scss
Outdated
| width: 100%; | ||
| transform: translateY(-100%); | ||
| transition: height .25s; | ||
| background: rgb(0 0 0 / 0.5); |
There was a problem hiding this comment.
I get a compile error with make dist, it says:
Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
SassError: Function rgb is missing argument $green.
on line 36 of /srv/www/htdocs/owncloud/apps-external/files_mediaviewer/src/styles/default.scss
>> background: rgb(0 0 0 / 0.5);
I think you should add commas
Fix rgba format
ChrisEdS
force-pushed
the
fix-scrubber
branch
from
9f5a99a
to
62cbc58
Compare
Confirmed fixed in 1.0.4Tested with google chrome and firefox. The scrubber background is much darker than in the above screenshots, but easily recognizable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I added a background color to the scrubber. Especially with long videos it was not obvious at the beginning that there is a scrubber.
The height of the scrubber was increased by 5 pixels. @PVince81 can you do a re-test with these changes?
Fixes: #26
Screenshot
Before:
After:
Manually tested in Chrome browser