Skip to content
This repository has been archived by the owner on Jun 19, 2023. It is now read-only.

[Feature Request] Show cover/album art when playing music #935

Open
mmattel opened this issue Sep 5, 2017 · 10 comments
Open

[Feature Request] Show cover/album art when playing music #935

mmattel opened this issue Sep 5, 2017 · 10 comments

Comments

@mmattel
Copy link
Contributor

mmattel commented Sep 5, 2017

IOS 10.3.3 Client 3.6.2

When download a music track and play it, you get the quicktime symbol as cover/album art.
When you lock the screen during playing, IOS will show you the cover - if embedded in the file.

Feature Request: let the client also show the cover/album art when embedded in the file.

@nasli
Copy link
Contributor

nasli commented Dec 27, 2017

Would be cool indeed, thanks for your suggestion @mmattel
This is not in our roadmap for now but contributions are welcome!

@andrevz
Copy link
Contributor

andrevz commented Apr 13, 2019

Hello @nasli I just created a PR #1105 for this feature, I am new to iOS development so any comment or suggest is welcome, please find attached some screen shots of the feature
Screen Shot 2019-04-12 at 11 39 41 PM
Screen Shot 2019-04-12 at 11 43 32 PM

@nasli
Copy link
Contributor

nasli commented Apr 15, 2019

Thank you for your contribution @andrevz, I'm sure a lot of people will love it !!

And congratulations on your journey as iOS dev! 🎉🎉

Glad that you are contributing to this project and for new features at this time ownCloud is focusing the effort on the newest and most modern application you can find here.

I recommend you to keep an eye on it and hope ownCloud can count on you there too.

Check if this feature is not already available in the new app, @michaelstingl or @jesmrec can help you with that.

@mmattel
Copy link
Contributor Author

mmattel commented Apr 16, 2019

If this function is in the new app already, pls link.
For the time up to the new app gets released, this would be great to get it in (properly tested of course 😄)

@hosy
Copy link
Collaborator

hosy commented Apr 16, 2019

@mmattel this is currently not implemented in the new app.
@andrevz are you interested to implement this feature in our new iOS app? The new app is written in Swift.

@mmattel
Copy link
Contributor Author

mmattel commented Apr 16, 2019

@hosy thanks for the idea, but I am not able to do this due to completely lack of Swift.
But @andrevz might be able to do so as she has already written that code.

@andrevz
Copy link
Contributor

andrevz commented Apr 16, 2019

@hosy @mmattel yep I am interested; I am going to try to add the same feature for the new app

@jesmrec
Copy link
Contributor

jesmrec commented Apr 17, 2019

you are very welcome @andrevz. Do not hesitate in asking everything you need.

@andrevz
Copy link
Contributor

andrevz commented Apr 18, 2019

@jesmrec sure, I was reviewing the new architecture, and have some doubts about where the ui image view should be generated Client or SDK? and How the player is generated? (I lost the track at DisplayViewController thank you

@jesmrec
Copy link
Contributor

jesmrec commented Apr 22, 2019

I guess the UI object and player are generated in the client. but @mneuwert, @felix-schwarz and @hosy will answer more accurately. You can open an issue in the ios-app repository in which the discussion can go on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants