Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] copy test dependencies from the ownCloud/core #5280

Merged
merged 11 commits into from
Jan 5, 2023
Merged

[tests-only][full-ci] copy test dependencies from the ownCloud/core #5280

merged 11 commits into from
Jan 5, 2023

Conversation

kiranparajuli589
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 commented Dec 22, 2022 •
edited by phil-davis
Loading

Description

Copy test infrastructure from the oC/core repository

Related Issue

#5094

Motivation and Context

To remove the oC/core dependency for the acceptance tests run

How Has This Been Tested?

  • 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kiranparajuli589 kiranparajuli589 force-pushed the remove-ownCloud-core-test-dependency branch 9 times, most recently from 968ad3d to 025a07d Compare December 27, 2022 06:39
@kiranparajuli589 kiranparajuli589 self-assigned this Dec 27, 2022
@kiranparajuli589 kiranparajuli589 force-pushed the remove-ownCloud-core-test-dependency branch from 025a07d to 95d57cd Compare December 27, 2022 06:48
@kiranparajuli589 kiranparajuli589 marked this pull request as ready for review December 27, 2022 07:21
@kiranparajuli589 kiranparajuli589 force-pushed the remove-ownCloud-core-test-dependency branch 3 times, most recently from 11ed33d to 92a3766 Compare December 27, 2022 08:52
@phil-davis
Copy link
Contributor

Note: we will leave this here until next week. Also leave #5306
I will switch it to draft for now.

I would like to double-check that all other test changes have been ported the same into both master and stable-2.0 branches, and get any recent test code changes that have happened in core. And then merge when we are happy that everything is "in sync".

@phil-davis phil-davis marked this pull request as draft December 30, 2022 06:30
@saw-jan saw-jan mentioned this pull request Jan 4, 2023
Closed
13 tasks
@phil-davis phil-davis force-pushed the remove-ownCloud-core-test-dependency branch from 27ea21f to 35d4cb5 Compare January 5, 2023 03:36
@phil-davis phil-davis marked this pull request as ready for review January 5, 2023 03:44
@phil-davis
Copy link
Contributor

I cherry-picked the rest of the commits from PR #5306 (stable-2.0 version of this). CI is running now, hopefully it passes and we can review and merge this.

@sonarcloud
Copy link

sonarcloud bot commented Jan 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

individual-it
individual-it approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codacy isn't happy with the run.sh script, if that does not make CI in other PRs fail I think we can merge this and fir the run.sh in a separate PR
Or we fix the run.sh in stable and forward port both PRs at the same time to master

@kiranparajuli589
Copy link
Contributor Author

kiranparajuli589 commented Jan 5, 2023 •
edited
Loading

codacy isn't happy with the run.sh script, if that does not make CI in other PRs fail I think we can merge this and fir the run.sh in a separate PR Or we fix the run.sh in stable and forward port both PRs at the same time to master

strange 😕 run.sh is excluded for the codacy check in .codacy.yml https:/owncloud/ocis/pull/5280/files#diff-6e27af35533eda2e3e82d6d7f8654c26824396797716d37ac7df096a1b090503

@phil-davis
Copy link
Contributor

phil-davis commented Jan 5, 2023 •
edited
Loading

Codacy is not a required status, so it will not stop merging. I will merge this, and then we can move on to various cleanups...

@phil-davis phil-davis merged commit c067409 into master Jan 5, 2023
@delete-merged-branch delete-merged-branch bot deleted the remove-ownCloud-core-test-dependency branch January 5, 2023 05:23
This was referenced Jan 5, 2023
Closed
Closed
This was referenced Jan 9, 2023
Merged
Merged
Open
@saw-jan saw-jan mentioned this pull request Jan 30, 2023
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grgprarup grgprarup grgprarup left review comments

@phil-davis phil-davis phil-davis approved these changes

@individual-it individual-it individual-it approved these changes

@ScharfViktor ScharfViktor Awaiting requested review from ScharfViktor

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@SagarGi SagarGi Awaiting requested review from SagarGi

@saw-jan saw-jan Awaiting requested review from saw-jan

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

Assignees

@kiranparajuli589 kiranparajuli589

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kiranparajuli589 @grgprarup @phil-davis @SwikritiT @individual-it @saw-jan