Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor forms to implement react-final-forms #68

Closed
sepulzera opened this issue Nov 1, 2022 · 0 comments
Closed

Refactor forms to implement react-final-forms #68

sepulzera opened this issue Nov 1, 2022 · 0 comments
Assignees
Labels
Milestone

Comments

@sepulzera
Copy link

React sucks at forms. There are plenty of libs for forms that suck too.

Anyway, not using any libs sucks even more. Thus I will go with react-final-form. I won't use formik because it has poor performance, as changing a field will re-render the whole form.

React-final-forms seems to be right choice, but its docu sucks.


By solving this issue, I hope to rule out some other nasty bugs and performance issues, like #59, submit button disabling behaviour and onSubmitSuccess-Callbacks. I also expect quite some performance gains, especially for the recipe form ingredients groupbox. I don't expect the code to become any cleaner or easier to re-use; react sucks too much in this regard.

@sepulzera sepulzera added this to the v3.1.0 milestone Nov 1, 2022
@sepulzera sepulzera self-assigned this Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant