Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker production: Add support for ssl #80

Closed
sepulzera opened this issue Nov 23, 2022 · 1 comment
Closed

docker production: Add support for ssl #80

sepulzera opened this issue Nov 23, 2022 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@sepulzera
Copy link

The docker production build is served by nginx. The nginx configuration does not support ssl to serve the content via https. Also there is no way to add this functionality into the production build, e. g. change the nginx default.conf file.

There is some docs about how to create a (additional) proxy server to do the encryption. But running another http server just to add some common feature seems rather odd.

http should not be used to serve sensitive data, and therefore should not being used to serve OwnRecipes (and its login etc.). OwnRecipes should include a simple way to add ssl.

@sepulzera sepulzera added documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed labels Nov 23, 2022
@sepulzera sepulzera added this to the v3.1.1 milestone Nov 23, 2022
@sepulzera sepulzera self-assigned this Nov 23, 2022
sepulzera added a commit to ownrecipes/ownrecipes-nginx that referenced this issue Nov 23, 2022
sepulzera added a commit that referenced this issue Nov 23, 2022
@sepulzera
Copy link
Author

Feature added as experimental. I couldn't test for production on a dedicated server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Development

No branches or pull requests

1 participant