Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace kapt with ksp and update dependencies #1560

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Replace kapt with ksp and update dependencies #1560

merged 2 commits into from
Jul 24, 2024

Conversation

simophin
Copy link

@simophin simophin commented Jul 23, 2024 •
edited
Loading

In order to use KSP, I have to:

  1. Update kotlin version to the 1.9.x series (updating to 2.0 seems a bit risky at this moment)
  2. Update compose compiler to match the kotlin update
  3. Deprecated generated APIs aren't usable anymore in Glide so I followed the official guide to do the replacement (https://bumptech.github.io/glide/doc/generatedapi.html)

AL-Session
AL-Session approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@AL-Session AL-Session left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! We could probably push to Kotlin version 1.9.25 if we didn't want to make the jump to 2.0.0 yet - will leave that decision up to you & the gang. Approved!

gradle.properties Show resolved Hide resolved
@simophin simophin merged commit 631d93c into oxen-io:dev Jul 24, 2024
1 check passed
@simophin simophin deleted the ksp branch July 24, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AL-Session AL-Session AL-Session approved these changes

@ThomasSession ThomasSession ThomasSession approved these changes

@bemusementpark bemusementpark Awaiting requested review from bemusementpark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simophin @AL-Session @ThomasSession