Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libpq][hack] Workaround for libpq #214

Merged
merged 4 commits into from
Sep 1, 2021
Merged

[libpq][hack] Workaround for libpq #214

merged 4 commits into from
Sep 1, 2021

Conversation

smklein
Copy link
Collaborator

@smklein smklein commented Sep 1, 2021

See #213 for full details - this solution is a hack, but it enables building/running on illumos.

@smklein smklein changed the title [hack] Workaround for libpq [libpq][hack] Workaround for libpq Sep 1, 2021
@smklein smklein requested review from bnaecker and davepacheco and removed request for bnaecker September 1, 2021 20:47
Copy link
Collaborator

@bnaecker bnaecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as a quick fix, but I'd probably get some other comments. Nothing seems like a "good" answer, so this might just be the least bad for the time being. Thanks for doing this!

README.adoc Outdated Show resolved Hide resolved
@jclulow
Copy link
Collaborator

jclulow commented Sep 1, 2021

FWIW, one could also modify the binaries to include the correct runpath; e.g.,

$ cargo build
   Compiling omicron-nexus v0.1.0 (/ws/omicron/omicron-nexus)
    Finished dev [unoptimized + debuginfo] target(s) in 8.48s

$ target/debug/nexus
ld.so.1: nexus: fatal: libpq.so.5: open failed: No such file or directory
Killed

$ /usr/bin/elfedit -e 'dyn:runpath /opt/ooce/pgsql-13/lib/amd64:/usr/gcc/10/lib/amd64'  target/debug/nexus

$ target/debug/nexus
nexus: parsing arguments: error: The following required arguments were not provided:
    <CONFIG_FILE_PATH>

USAGE:
    nexus [FLAGS] <CONFIG_FILE_PATH>

For more information try --help

@smklein smklein merged commit b72c31e into main Sep 1, 2021
@smklein smklein deleted the pg-hack branch September 1, 2021 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants