Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cppcheck: Suppress errors #306

Merged
merged 4 commits into from
Aug 2, 2020
Merged

cppcheck: Suppress errors #306

merged 4 commits into from
Aug 2, 2020

Conversation

ueno
Copy link
Member

@ueno ueno commented Aug 2, 2020

No description provided.

This suppresses the cppcheck error:
  common/constants.c:649,error,invalidFunctionArg,Invalid bsearch() argument nr 3. The value is -1 but the valid values are '0:'.
This suppresses the cppcheck errors:
  p11-kit/test-mock.c:769,error,uninitvar,Uninitialized variable: count
  p11-kit/test-mock.c:776,error,uninitvar,Uninitialized variable: count
  p11-kit/test-mock.c:783,error,uninitvar,Uninitialized variable: count
This suppresses the cppcheck error:
  p11-kit/test-deprecated.c:481,error,uninitvar,Uninitialized variable: manufacturerID
This suppresses the cppcheck error:
  trust/anchor.c:243,error,uninitvar,Uninitialized variable: count

Also fixes calloc invocation when the slot count is 0.
@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/p11-glue-p11-kit-306
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@ueno ueno merged commit d10c5a3 into p11-glue:master Aug 2, 2020
@ueno ueno added the bug label Aug 18, 2020
@ueno ueno added this to the 0.23.21 milestone Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant