Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: Fix infloop in p11_path_build #326

Closed
wants to merge 1 commit into from

Conversation

ueno
Copy link
Member

@ueno ueno commented Oct 22, 2020

If p11_path_build is called with 2 or more arguments and the non-first argument is an empty string (""), it previously fell into an infloop.

Reported by Karel Srot.

If p11_path_build is called with 2 or more arguments and the non-first
argument is an empty string (""), it previously fell into an infloop.

Reported by Karel Srot.
@ueno ueno added the bug label Oct 22, 2020
@t184256
Copy link
Contributor

t184256 commented Oct 27, 2020

It does the job and avoids the infinite loop on encountering "", but it didn't feature stripping leading separators on the follow-up path component. I tried addressing separator duplication by moving the said stripping to the top of the loop, here's the result: t184256@d9a9061

@ueno
Copy link
Member Author

ueno commented Oct 27, 2020

Cool, would you mind filing a new PR superseding this then? :-)

@ueno
Copy link
Member Author

ueno commented Oct 27, 2020

Superseded by #327.

@ueno ueno closed this Oct 27, 2020
@ueno ueno added this to the 0.23.22 milestone Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants