Link libp11-kit so that it cannot unload #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libp11-kit installs a pthread_atfork() callback to count forks. If the library gets unloaded, a stale pointer is called on the next fork(), leading to a crash. This fix adds -z nodelete linker flag so that libp11-kit cannot be unloaded. Unfortunately, that only fixes the problem for GNU ld. More additionnal flags will be required for other linkers.
ueno
approved these changes
Aug 24, 2021
There was a problem hiding this comment.
Thank you; that makes sense. Would you also like to add the same logic to:
https:/p11-glue/p11-kit/blob/0.24.0/p11-kit/meson.build#L55
|
On Tue, Aug 24, 2021 at 10:36:33AM -0700, Daiki Ueno wrote:
@ueno approved this pull request.
Thank you; that makes sense. Would you also like to add the same logic to:
https:/p11-glue/p11-kit/blob/0.24.0/p11-kit/meson.build#L55
I am less familiar with that than with autotools. I would be glad if
you beat me at doing it.
…--
Emmanuel Dreyfus
***@***.***
|
|
OK, let me try; thank you for the patch! |
|
#384 is the follow-up for meson. |
|
On Tue, Aug 24, 2021 at 10:36:33AM -0700, Daiki Ueno wrote:
Thank you; that makes sense.
Thinking at it afterwards, I wonder if it deserves a comment
in configure.ac noting why we want it to get the undelete flag.
…--
Emmanuel Dreyfus
***@***.***
|
|
Sure, I've amended the comment in #384. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libp11-kit installs a pthread_atfork() callback to count forks. If the
library gets unloaded, a stale pointer is called on the next fork(),
leading to a crash.
This fix adds -z nodelete linker flag so that libp11-kit cannot be
unloaded. Unfortunately, that only fixes the problem for GNU ld.
More additionnal flags will be required for other linkers.