Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat: Fix detection of O_BINARY and O_CLOEXEC #428

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

ueno
Copy link
Member

@ueno ueno commented Jul 29, 2022

Previously those macros were defined as 0 unless <fcntl.h> was
included before "compat.h".

Reported and fix suggested by Kevin Adler in:
#425

Fixes: #425
Signed-off-by: Daiki Ueno [email protected]

@coveralls
Copy link

coveralls commented Jul 29, 2022

Coverage Status

Coverage decreased (-0.002%) to 71.35% when pulling 324b389 on ueno:wip/dueno/fcntl into 23e9790 on p11-glue:master.

Copy link
Contributor

@ansasaki ansasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Previously those macros were defined as 0 unless <fcntl.h> was
included before "compat.h".

Reported and fix suggested by Kevin Adler in:
p11-glue#425

Signed-off-by: Daiki Ueno <[email protected]>
@ueno ueno merged commit 1046e0a into p11-glue:master Jul 29, 2022
@ueno ueno added this to the 0.25.0 milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compat definitions of O_BINARY and O_CLOEXEC broken
3 participants