Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PKCS#11 3.0 support to proxy #461

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

ZoltanFridrich
Copy link
Contributor

@ZoltanFridrich ZoltanFridrich commented Mar 3, 2023

Expands the proxy modules function list to support pkcs#11 3.0 functions.

@coveralls
Copy link

coveralls commented Mar 3, 2023

Coverage Status

Coverage: 69.448% (-2.2%) from 71.611% when pulling b726d68 on ZoltanFridrich:zfridric_devel4 into 095e521 on p11-glue:master.

@ZoltanFridrich ZoltanFridrich force-pushed the zfridric_devel4 branch 6 times, most recently from 4684ebf to 0707e94 Compare March 6, 2023 16:05
p11-kit/client.c Fixed Show fixed Hide fixed
@ZoltanFridrich ZoltanFridrich requested a review from ueno March 6, 2023 16:23
@ZoltanFridrich ZoltanFridrich self-assigned this Mar 7, 2023
Copy link
Member

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the first round of comments; maybe good to think about when to use CK_FUNCTION_LIST or CK_FUNCTION_LIST_3_0.

p11-kit/p11v3-module.map Outdated Show resolved Hide resolved
p11-kit/p11v3-module.def Outdated Show resolved Hide resolved
p11-kit/test-proxy.c Outdated Show resolved Hide resolved
p11-kit/proxy.c Outdated Show resolved Hide resolved
p11-kit/proxy.c Outdated Show resolved Hide resolved
p11-kit/proxy.c Outdated Show resolved Hide resolved
p11-kit/virtual.c Outdated Show resolved Hide resolved
p11-kit/client.c Outdated Show resolved Hide resolved
p11-kit/virtual.c Outdated Show resolved Hide resolved
p11-kit/virtual.c Show resolved Hide resolved
@ZoltanFridrich ZoltanFridrich force-pushed the zfridric_devel4 branch 11 times, most recently from 06c0457 to 525e4af Compare March 8, 2023 11:55
@ZoltanFridrich
Copy link
Contributor Author

All threads have been addressed.

@ZoltanFridrich ZoltanFridrich requested a review from ueno March 8, 2023 12:06
@ZoltanFridrich ZoltanFridrich changed the title [WIP] Support for PKCS #11 3.0 Add PKCS#11 3.0 support to proxy Mar 8, 2023
Copy link
Member

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you; looks good to me.

p11-kit/proxy.c Outdated Show resolved Hide resolved
p11-kit/proxy.c Show resolved Hide resolved
p11-kit/proxy.c Outdated Show resolved Hide resolved
@ZoltanFridrich ZoltanFridrich merged commit 466a31b into p11-glue:master Mar 9, 2023
@ueno ueno added this to the 0.25.0 milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants