Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: Support PKCS#11 3.0 #486

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Conversation

ueno
Copy link
Member

@ueno ueno commented Apr 9, 2023

This exports C_GetInterfaceList and C_GetInterface from the client module.

@coveralls
Copy link

coveralls commented Apr 9, 2023

Coverage Status

coverage: 69.881% (-0.05%) from 69.93% when pulling d159555 on ueno:wip/dueno/client-v3 into ccbe143 on p11-glue:master.

Copy link
Contributor

@ZoltanFridrich ZoltanFridrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I have some comments.

p11-kit/client.c Outdated Show resolved Hide resolved
p11-kit/client.c Show resolved Hide resolved
p11-kit/proxy.c Show resolved Hide resolved
p11-kit/client.c Fixed Show fixed Hide fixed
@ueno ueno force-pushed the wip/dueno/client-v3 branch 4 times, most recently from ab5aa06 to 09467d3 Compare April 12, 2023 07:50
ueno added 2 commits June 27, 2023 20:19
This adds a minor refactoring to get_interface_inlock:
- CK_RV for the return value instead of int
- Use "goto cleanup" instead of a chain of "if (rv == CKR_OK)"

Signed-off-by: Daiki Ueno <[email protected]>
This exports C_GetInterfaceList and C_GetInterface from the client
module.

Signed-off-by: Daiki Ueno <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants