Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make terminal output nicer #509

Merged
merged 1 commit into from
May 30, 2023
Merged

Make terminal output nicer #509

merged 1 commit into from
May 30, 2023

Conversation

ZoltanFridrich
Copy link
Contributor

@ZoltanFridrich ZoltanFridrich commented May 24, 2023 •
edited
Loading

  • adds URL highlighting to trust list command
  • adds colors to trust list command
  • adds colors to p11-kit list-modules command

Closes #393

@coveralls
Copy link

coveralls commented May 24, 2023 •
edited
Loading

Coverage Status

Coverage: 70.033% (-0.06%) from 70.093% when pulling c6caa6d on ZoltanFridrich:zfridric_devel2 into 2fbe188 on p11-glue:master.

@ZoltanFridrich ZoltanFridrich changed the title Make terminal output nicer [WIP] Make terminal output nicer May 25, 2023
@ZoltanFridrich ZoltanFridrich requested a review from ueno May 26, 2023 15:26
@ZoltanFridrich ZoltanFridrich changed the title [WIP] Make terminal output nicer Make terminal output nicer May 26, 2023
ueno
ueno reviewed May 27, 2023
View reviewed changes
p11-kit/lists.c Outdated Show resolved Hide resolved
@ZoltanFridrich ZoltanFridrich self-assigned this May 29, 2023
@ZoltanFridrich ZoltanFridrich force-pushed the zfridric_devel2 branch 2 times, most recently from e214e7e to 348ed19 Compare May 29, 2023 14:23
@ZoltanFridrich ZoltanFridrich requested a review from ueno May 29, 2023 14:27
ueno
ueno reviewed May 29, 2023
View reviewed changes
common/print.c Outdated Show resolved Hide resolved
ueno
ueno reviewed May 30, 2023
View reviewed changes
trust/list.c Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems May 30, 2023
View reviewed changes
common/print.c Fixed Show fixed Hide fixed
@ZoltanFridrich ZoltanFridrich force-pushed the zfridric_devel2 branch 3 times, most recently from 4c187eb to 59a36bc Compare May 30, 2023 11:34
@ZoltanFridrich ZoltanFridrich requested a review from ueno May 30, 2023 11:45
ueno
ueno approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might add some minor adjustment later, but overall it looks good to me.

common/print.h Outdated Show resolved Hide resolved
common/print.c Outdated Show resolved Hide resolved
@ZoltanFridrich
Add colors to p11-kit command-line tools
c6caa6d 
- adds URL highlighting to trust list command
- adds colors to trust list command
- adds colors to p11-kit list-modules command

Signed-off-by: Zoltan Fridrich <[email protected]>
@ZoltanFridrich ZoltanFridrich merged commit 1b14bfa into p11-glue:master May 30, 2023
@ZoltanFridrich ZoltanFridrich added this to the 0.25.0 milestone Jun 28, 2023
@brisingraerowing brisingraerowing mentioned this pull request Jul 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueno ueno ueno approved these changes

Assignees

@ZoltanFridrich ZoltanFridrich

Labels
enhancement
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

Better terminal output for p11-kit and trust commands
3 participants
@ZoltanFridrich @coveralls @ueno