Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print CKA_ID in hexadecimal format #534

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

ueno
Copy link
Member

@ueno ueno commented Jul 22, 2023

p11-kit list-objects currently prints CKA_ID in a binary form, which does not render correctly on terminal. This is to print the attribute in hexadecimal, as p11tool does.

@ueno ueno requested a review from ZoltanFridrich July 22, 2023 08:16
@coveralls
Copy link

coveralls commented Jul 22, 2023

Coverage Status

coverage: 69.636% (-0.01%) from 69.65% when pulling a55dc3b on ueno:wip/dueno/list-objects-fixes into d98392b on p11-glue:master.

common/hex.h Outdated Show resolved Hide resolved
Copy link
Contributor

@ZoltanFridrich ZoltanFridrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Just some nits

@ueno ueno force-pushed the wip/dueno/list-objects-fixes branch from 3a4d13f to a55dc3b Compare July 26, 2023 06:19
@ueno ueno requested a review from ZoltanFridrich July 26, 2023 06:19
@ZoltanFridrich ZoltanFridrich merged commit 4d58e40 into p11-glue:master Jul 26, 2023
12 checks passed
@ueno ueno added this to the 0.25.1 milestone Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants