p11-kit list-tokens: New subcommand #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueno
force-pushed
the
wip/dueno/list-tokens
branch
4 times, most recently
from
8c746de
to
a502faa
Compare
ZoltanFridrich
requested changes
Oct 4, 2023
This splits the logic to iterate over modules and tokens and print the details into two functions: the iteration and printing of CK_INFO and CK_TOKEN_INFO structures, so that the printing function (print_token_info) can be used for `p11-kit list-tokens`. This also makes slot listing more flexible to allow more than 256 slots. Signed-off-by: Daiki Ueno <[email protected]>
ueno
force-pushed
the
wip/dueno/list-tokens
branch
from
a502faa
to
6de40fc
Compare
ZoltanFridrich
requested changes
Oct 4, 2023
This adds a new subcommand "list-tokens" to the p11-kit command, which is similar to "list-modules" but only prints tokens. This would make scripting tasks easier. Signed-off-by: Daiki Ueno <[email protected]>
ueno
force-pushed
the
wip/dueno/list-tokens
branch
from
6de40fc
to
c94d6fa
Compare
|
Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new subcommand "list-tokens" to the p11-kit command, which
is similar to "list-modules" but only prints tokens. This would make
scripting tasks easier.
Fixes: #554