Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "template" parameters in iter.h #616

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Rename "template" parameters in iter.h #616

merged 1 commit into from
Jan 10, 2024

Conversation

ZoltanFridrich
Copy link
Contributor

@ZoltanFridrich ZoltanFridrich commented Jan 9, 2024 •
edited
Loading

Fixes the following errors when compiling C++ source file linked with p11-kit:

/usr/include/p11-kit-1/p11-kit/iter.h:127:76: error: invalid parameter name: 'template' is a keyword
                                                             CK_ATTRIBUTE *template,
                                                                          ^
/usr/include/p11-kit-1/p11-kit/iter.h:131:76: error: invalid parameter name: 'template' is a keyword
                                                             CK_ATTRIBUTE *template,
                                                                          ^
2 errors generated.

Closes #610

@ZoltanFridrich ZoltanFridrich self-assigned this Jan 9, 2024
@coveralls
Copy link

coveralls commented Jan 9, 2024 •
edited
Loading

Coverage Status

coverage: 69.452% (+0.03%) from 69.425%
when pulling 4ed429d on ZoltanFridrich:zfridric_devel2
into 304db35 on p11-glue:master.

@ZoltanFridrich ZoltanFridrich merged commit 3fb878a into p11-glue:master Jan 10, 2024
14 checks passed
@ZoltanFridrich ZoltanFridrich added this to the 0.25.4 milestone Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueno ueno ueno approved these changes

Assignees

@ZoltanFridrich ZoltanFridrich

Labels
None yet
Projects
None yet
Milestone
0.25.4
Development

Successfully merging this pull request may close these issues.

consider renaming parameter name "template"
3 participants
@ZoltanFridrich @coveralls @ueno