Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: check value length before writing the value #629

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

ZoltanFridrich
Copy link
Contributor

This is to prevent buffer overflow in case the value buffer is too short to store the decoded value.

@coveralls
Copy link

coveralls commented Mar 14, 2024

Coverage Status

coverage: 69.531% (-0.02%) from 69.548%
when pulling f753e56 on ZoltanFridrich:zfridric_devel
into ebfc19c on p11-glue:master.

@ZoltanFridrich ZoltanFridrich changed the title rpc: check value length before reading the value rpc: check value length before writing the value Mar 14, 2024
Copy link
Member

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ZoltanFridrich ZoltanFridrich merged commit f53bdc2 into p11-glue:master Mar 14, 2024
14 checks passed
@ZoltanFridrich ZoltanFridrich added this to the 0.25.4 milestone Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants