-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Having a "no matching interaction" on a single test crashes the entire suite #231
Labels
bug
Indicates an unexpected problem or unintended behavior
Comments
Thanks for the detailed bug report @chris-fa. I think you're right, the behaviour should be to carry on, and let any "fast fail" decision happen at the test framework (e.g. Jest, Mocha) level. |
mefellows
added a commit
that referenced
this issue
Oct 17, 2018
All successful/failed calls to pact.verify() should clear interactions so that subsequent tests don't det out of whack. NOTE: Promise.finally() would have been nicer, note for upgrade to latest TS in next major release. Fixes #231
OK, have made a fix in the latest release. Let us know if that fixes your issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Software versions
^5.9.1
8.11.3
Expected behaviour
Given I add an interaction
And I'm doing TDD red-green-refactor cycle
When my callApi module makes the HTTP request
And it doesn't match the defined interaction ("red" part of the cycle)
Then only the that test should crash
And the other tests should have consistent results
Actual behaviour
All the tests that execute after the one that didn't match crashes.
Steps to reproduce
Relevant log files
Update
I noticed the tests that pass have this line in the logs:
This line is not present after a verification that failed. Maybe that's the problem?
The text was updated successfully, but these errors were encountered: