Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEV-1040] Rendering component OpenAPI Gitbook #353

Merged
merged 55 commits into from
Jan 31, 2024
Merged

[DEV-1040] Rendering component OpenAPI Gitbook #353

merged 55 commits into from
Jan 31, 2024

Conversation

jeremygordillo
Copy link
Collaborator

@jeremygordillo jeremygordillo commented Oct 26, 2023 •
edited by marcobottaro
Loading

List of Changes

  • Add markdoc config to transform swagger blocks into React components
  • Create React components to render the OpenAPI spec

Motivation and Context

Show API specifications from yaml and json files in the presence of the swagger gitbook block

How Has This Been Tested?

Checking if the blocks on this page (on localhost) are rendered

Screenshots (if appropriate):

screencast-localhost_3000-2023.11.29-16_05_07.webm
screencast-localhost_3000-2023.11.29-16_03_57.webm

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jeremygordillo jeremygordillo self-assigned this Oct 26, 2023
@jeremygordillo jeremygordillo marked this pull request as ready for review November 9, 2023 13:59
@github-actions github-actions bot added the stale label Dec 22, 2023
@jeremygordillo
move eslint-disable rule
4af1250
@jeremygordillo
Merge branch 'main' into openapi
c6d4cda 
# Conflicts:
#	apps/nextjs-website/src/messages/it.json
#	package-lock.json
@jeremygordillo jeremygordillo requested a review from a team as a code owner January 11, 2024 17:17
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 11, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: dd046c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
nextjs-website Minor
gitbook-docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@marcobottaro marcobottaro changed the title [DEV-1040] Rendering componente OpenAPI Gitbook [DEV-1040] Rendering component OpenAPI Gitbook Jan 11, 2024
@github-actions github-actions bot removed the stale label Jan 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Branch is not up to date with base branch

@jeremygordillo it seems this Pull Request is not updated with base branch.
Please proceed with a merge or rebase to solve this.

@github-actions GitHub Actions
Copy link
Contributor

Jira Pull Request Link

This Pull Request refers to the following Jira issue DEV-1040

@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 800 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions GitHub Actions
Copy link
Contributor

📦 Next.js Bundle Analysis for nextjs-website

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 75.59 KB (🟡 +17 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@datalek datalek merged commit b2f50b8 into main Jan 31, 2024
9 of 10 checks passed
@datalek datalek deleted the openapi branch January 31, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datalek datalek datalek approved these changes

@MarcoPonchia MarcoPonchia MarcoPonchia approved these changes

@marcobottaro marcobottaro marcobottaro approved these changes

@tommaso1 tommaso1 Awaiting requested review from tommaso1 tommaso1 is a code owner

@kin0992 kin0992 Awaiting requested review from kin0992

Assignees

@jeremygordillo jeremygordillo

Labels
packages size/large website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeremygordillo @datalek @MarcoPonchia @marcobottaro