[#174416949] Replace tslint with eslint (#752)

* [#174416949] Replace italia-tslint-rules (tslint) with @pagopa/eslint-config

[#174416949] Restore app.ts layout

* [#174416949] Apply eslint to app.ts after rebase

* [#174416949] Refactor casting with unknown instead any

* [#174416949] Fix MessageSubject import path

* [#174416949] Revert .test.ts changes

* [#174416949] Add NL EOF

* [#174416949] Remove useless tslint:disable comment

* [#174416949] Remove useless eslint-disable-next-line

* [#174416949] Add eslint cache into lint script

* [#174416949] Fix after rebase

* [#174416949] Fix lint error (bug)

* [#174416949] Fix false positive no-shadow on enum

* [#174416949] Upgrade @pagopa/eslint-config

.eslintignore

@@ -0,0 +1,9 @@
+# Never lint node_modules
+node_modules
+
+# We shouldn't lint assets nor generated files
+generated
+
+**/__tests__/*
+**/__mocks__/*
+Dangerfile.*

.eslintrc.js

@@ -0,0 +1,29 @@
+module.exports = {
+ "env": {
+ "browser": true,
+ "es6": true,
+ "node": true
+ },
+ "ignorePatterns": [
+ "node_modules",
+ "generated",
+ "**/__tests__/*",
+ "**/__mocks__/*",
+ "Dangerfile.*",
+ "*.d.ts"
+ ],
+ "parser": "@typescript-eslint/parser",
+ "parserOptions": {
+ "project": "tsconfig.json",
+ "sourceType": "module"
+ },
+ "extends": [
+ "@pagopa/eslint-config/strong",
+ ],
+ "rules": {
+ "prefer-arrow/prefer-arrow-functions": "off",
+ "@typescript-eslint/naming-convention": "off",
+ "@typescript-eslint/explicit-function-return-type": "off",
+ "no-invalid-this": "off"
+ }
+};

.gitignore

@@ -23,6 +23,7 @@ npm-debug.log
 
 # Exclude typescript generated javascript files.
 *.js
+!.eslintrc.js
 !.release-it.js
 *.js.map
 
@@ -44,3 +45,6 @@ local.*
 
 # Exclude Codetour plugin folder
 .tours
+
+# Exclude ESLint cache file
+.eslintcache

package.json

@@ -19,8 +19,8 @@
  "build": "tsc",
  "build-noemit": "tsc --noEmit",
  "hot-reload": "nodemon --legacy-watch --watch ./src --inspect=0.0.0.0:5859 --nolazy src/server.js",
- "lint": "tslint -p . -c tslint.json -t verbose",
- "lint-autofix": "tslint -p . -c tslint.json -t verbose --fix",
+ "lint": "eslint . -c .eslintrc.js --ext .ts,.tsx --cache",
+ "lint-autofix": "eslint . -c .eslintrc.js --ext .ts,.tsx --fix",
  "prettify": "prettier --write \"./**/*.ts\"",
  "test": "jest -i",
  "test:coverage": "dotenv -e .env.example -- jest -i --coverage",
@@ -89,6 +89,7 @@
  "xmldom": "^0.1.27"
  },
  "devDependencies": {
+ "@pagopa/eslint-config": "^1.1.1",
  "@types/apicache": "^1.2.0",
  "@types/dotenv": "^4.0.2",
  "@types/express": "4.16.0",
@@ -119,7 +120,7 @@
  "danger": "^4.0.2",
  "danger-plugin-digitalcitizenship": "^0.3.1",
  "dotenv-cli": "^3.1.0",
- "italia-tslint-rules": "^1.1.3",
+ "eslint-plugin-prettier": "^3.3.1",
  "italia-utils": "^6.3.0",
  "jest": "^23.6.0",
  "lolex": "4.2.0",
@@ -136,7 +137,6 @@
  "swagger-parser": "^5.0.5",
  "ts-jest": "^23.10.4",
  "ts-node": "^7.0.1",
- "tslint": "^5.11.0",
  "typescript": "^3.6.2"
  },
  "jest": {

src/@types/passport-auth-token/index.d.ts

@@ -14,7 +14,6 @@ interface IVerifyOptions {
 
 type VerifyFunction = (
  token: string,
- // tslint:disable-next-line:no-any
  done: (error: any, user?: any, options?: IVerifyOptions) => void
 ) => void;
 

src/__mocks__/request.ts

@@ -1,5 +1,3 @@
-// tslint:disable:no-any
-
 /**
  * mockReq
  * @returns {{header, accepts, acceptsEncodings, acceptsEncoding, acceptsCharsets, acceptsCharset, acceptsLanguages, acceptsLanguage, range, param, is, reset: resetMock}}

src/__mocks__/response.ts

@@ -1,5 +1,3 @@
-// tslint:disable:no-any
-
 /**
  * mockRes
  * @returns {{append, attachment, cookie, clearCookie, download, end, format, get, json, jsonp, links, location, redirect, render, send, sendFile, sendStatus, set, status, type, vary, reset: resetMock}}