Deterministic Bundle Trees #309
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeMoorJasper
approved these changes
Dec 16, 2017
pomle
reviewed
Dec 16, 2017
| await this.loadAsset(assetDep); | ||
| } | ||
| return applyFunction; | ||
| }) | ||
| ); |
There was a problem hiding this comment.
Is applyFunctions only job to be run later. Then would it be leaner to chain .forEach(fn => fn()) do you think?
There was a problem hiding this comment.
That would work as well. I felt the current was more readable.
There was a problem hiding this comment.
All good. Confirmed test is stable on my end now.
|
👍 |
pomle
approved these changes
Dec 16, 2017
devongovett
added a commit
that referenced
this pull request
Dec 19, 2017
|
Thanks for looking into this! I refactored it slightly to be two loops: one that resolves and loads assets, and the second which assigns them back to deps. 539ade1 |
|
Awesome, definitely a bit cleaner. Hopefully the last we see of this test failing! |
devongovett
added a commit
that referenced
this pull request
Oct 15, 2018
devongovett
added a commit
that referenced
this pull request
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #219.
Promise.allguarantees order. This delays thesetoperations until after processing so that they always occur in the same order.