Babel: Recognize peerDependencies in isJSX #6497
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
The Babel transformer auto-enables JSX support when a React-like library is listed in
dependencies
ordevDependencies
, but not inpeerDependencies
. This PR fixes that.Compare the existing code in
JSTransformer.js
:parcel/packages/transformers/js/src/JSTransformer.js
Lines 127 to 132 in 5504627
🚨 Test instructions
This is a quick & minimal change and I'm currently just eyeballing it 😅 I have not (yet) familiarised myself with Parcel's testing setup. Happy to take pointers and update this PR with tests as necessary.
✔️ PR Todo