Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests to GitHub actions #7678

Merged
merged 9 commits into from
Feb 22, 2022
Merged

Move tests to GitHub actions #7678

merged 9 commits into from
Feb 22, 2022

Conversation

wbinnssmith
Copy link
Contributor

@wbinnssmith wbinnssmith commented Feb 9, 2022

This moves our test infrastructure from Azure pipelines to GitHub actions.

The flow and lint steps don't run on user's machines, and have minimal platform differences, so those currently run only on Ubuntu here.

I've also duplicated some setup (e.g. running yarn) in an effort to parallelize the jobs for faster feedback.

  • Lint
  • Flow
  • Tests

@height
Copy link

height bot commented Feb 9, 2022

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@wbinnssmith wbinnssmith force-pushed the wbinnssmith/github-actions branch 4 times, most recently from 0772373 to 2341eb5 Compare February 9, 2022 04:57
@parcel-benchmark
Copy link

parcel-benchmark commented Feb 9, 2022

Benchmark Results

Kitchen Sink 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

React HackerNews ✅

Timings

Description Time Difference
Cold 9.46s +135.00ms
Cached 460.00ms +7.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/logo.c5bb83f1.png 246.00b +0.00b 4.92s +822.00ms ⚠️

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.02m -1.69s
Cached 1.49s +46.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Three.js ✅

Timings

Description Time Difference
Cold 6.67s +63.00ms
Cached 289.00ms +6.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@parcel-benchmark
Copy link

Benchmark Results

Kitchen Sink 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

React HackerNews ✅

Timings

Description Time Difference
Cold 10.00s +160.00ms
Cached 481.00ms +8.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.09m -539.00ms
Cached 1.43s -119.00ms 🚀

Cold Bundles

Bundle Size Difference Time Difference
dist/editorView.d13d38ad.js 594.92kb +0.00b 47.97s +12.33s ⚠️
dist/popup.f944d52c.js 209.67kb +0.00b 47.97s +12.33s ⚠️
dist/Toolbar.b2284ccb.js 107.23kb +0.00b 47.97s +12.33s ⚠️
dist/Modal.ec0ec3f8.js 45.33kb +0.00b 47.97s +12.33s ⚠️
dist/ui.39c61c40.js 14.94kb +0.00b 47.97s +12.33s ⚠️
dist/smartMediaEditor.27b49d9d.js 13.25kb +0.00b 47.97s +12.33s ⚠️
dist/dropzone.0d17e26c.js 12.16kb +0.00b 47.97s +12.33s ⚠️
dist/EmojiPickerComponent.8fb3dd15.js 3.73kb +0.00b 47.97s +12.33s ⚠️
dist/dropzone.d03df26a.js 3.29kb +0.00b 47.97s +12.33s ⚠️
dist/clipboard.7ceac12b.js 2.93kb +0.00b 47.97s +12.33s ⚠️
dist/ResourcedEmojiComponent.9106318a.js 2.12kb +0.00b 47.97s +12.33s ⚠️
dist/browser.d28fd36c.js 1.69kb +0.00b 47.97s +12.33s ⚠️
dist/media-card-analytics-error-boundary.bead5bf1.js 1.12kb +0.00b 47.97s +12.33s ⚠️
dist/media-picker-analytics-error-boundary.3df18700.js 966.00b +0.00b 47.97s +12.33s ⚠️
dist/simpleHasher.a4c0be3d.js 643.00b +0.00b 47.97s +12.33s ⚠️

Cached Bundles

No bundle changes detected.

Three.js ✅

Timings

Description Time Difference
Cold 6.87s +123.00ms
Cached 351.00ms +2.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@wbinnssmith wbinnssmith force-pushed the wbinnssmith/github-actions branch 8 times, most recently from ae1c841 to d7df0bc Compare February 10, 2022 22:49
@wbinnssmith wbinnssmith marked this pull request as ready for review February 11, 2022 22:48
@@ -1,13 +1,102 @@
on: pull_request

name: Generate benchmarks
name: Test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rename this file to test.yml? main was a bit of a weird name choice from me, sorry

@devongovett devongovett merged commit 1094a12 into v2 Feb 22, 2022
@devongovett devongovett deleted the wbinnssmith/github-actions branch February 22, 2022 17:37
gorakong pushed a commit that referenced this pull request Nov 3, 2022
* upstream/v2: (26 commits)
  Replace typeof before DCE (#7788)
  Bump lmdb (#7797)
  Upgrade flow to 0.173.0 (#7809)
  Prevent `term-size` from being bundled (#7750)
  Pin [email protected] (#7763)
  Fix Windows CI (#7774)
  Upgrade Flow to 0.171.0 (#7667)
  Move tests to GitHub actions (#7678)
  v2.3.2
  Fix autoinstalling node builtins (#7735)
  Fix lint
  Use pinned versions
  Don't build native packages again during publish step
  Fix build
  Fix autoinstall
  v2.3.1
  Add diagnostic for failed autoinstall of node polyfill (#7682)
  v2.3.0
  Changelog for 2.3.0
  Support React 18 prereleases and experimental versions with automatic JSX runtime (#7642)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants