Upgrade Flow to 0.174.1 #7849
Merged
Upgrade Flow to 0.174.1 #7849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbinnssmith
commented
Mar 22, 2022
packages/core/core/src/AssetGraph.js
Outdated
| @@ -542,7 +542,7 @@ export default class AssetGraph extends ContentGraph<AssetGraphNode> { | |||
|
|
|||
| getIncomingDependencies(asset: Asset): Array<Dependency> { | |||
| let nodeId = this._contentKeyToNodeId.get(asset.id); | |||
| if (!nodeId) { | |||
| if (nodeId == null) { | |||
There was a problem hiding this comment.
Shouldn't this throw if we're asking for an asset that the graph doesn't know about?
There was a problem hiding this comment.
That would make sense. Does any caller rely on this not throwing?
There was a problem hiding this comment.
Doesn't seem like it — tests continue to pass. Updated it to do this 😄
Benchmark ResultsKitchen Sink 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... React HackerNews ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. AtlasKit Editor 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
added 2 commits
March 23, 2022 10:57
wbinnssmith
force-pushed
the
wbinnssmith/flow-0.174.1
branch
from
f43533c
to
f25b47c
Compare
lettertwo
approved these changes
Mar 23, 2022
mischnic
approved these changes
Mar 23, 2022
gorakong
pushed a commit
that referenced
this pull request
Nov 3, 2022
* upstream/v2: Upgrade Flow to 0.174.1 (#7849) v2.4.0 v2.4.0 changelog Bump Parcel CSS Dynamic imports priority fix closes #6980 (#7061) fix(transformers): errors.map is not a function (#7672) Make NodeResolver check realpath before resolving with `source` entry (#7846) docs: fix wrong location documents (#7689) Fix: escape double quote of url value in CSS `url()` (#7718) Update @parcel/css and add diagnostic for url dependencies in custom properties (#7845) Use relative path for bundle labels in bundle analysis (#7737) Allow use react-jsx transform in React 16.14.0 (#7728) Move to @parcel/css by default (#7821) Feature: pick PORT number also from .env file (#7819) Enable parsing static initialization blocks (#7839) Bump swc and prevent pure comment removal (#7833) Bump swc (#7777) Human readable file size in bundle analyzer report (#7766) Improve emoji support detection (#7775)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update found one sketchy null check, which was addressed.
Test Plan:
yarn flow check