Fix: join srcset in source with ", " #7918
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Fixes: #7884
I found this is parcel’s issue. htmlnano depends on srcset, npm module to parse srcset attribute and after sindresorhus/srcset#11 PR was merged
srcset
module cannot parse srcset attribute without whitespace after “,” becausehoge.png,bar.png
is a valid URL.However, parsel joins multiple image URLs in srcset attribute with “,” so this issue happens. parcel should join multiple image URLs in srcset attribute with “, “(with space), so I fixed so.
💻 Examples
into transformed into above by HTMLTransformer
but
srcset
module cannot parse this srcset attribute as a two image URLs.🚨 Test instructions
I fixed html srcset integration testcase to check output HTML's srcset is valid.
✔️ PR Todo