Support using packages in imports resolved by the glob resolver #8097
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Implements the ability for the glob resolver to resolve globs in packages, fixes #7945.
💻 Examples
With this change the glob resolver will work with a glob like
import('@scope/pkg/i18n/*.js')
, by first resolving@scope/pkg
to a path, and then appending/i18n/*.js
.🚨 Test instructions
An integration test has been added for both a regular
require
as well as an asyncimport
. Please provide feedback if the tests added are not comprehensive enough.✔️ PR Todo
unitintegration tests for this change